Re: svn commit: r1850344 - in /subversion/trunk/subversion: bindings/cxx/include/svnxx/ bindings/cxx/src/ include/

brane_at_apache.org wrote on Fri, 04 Jan 2019 10:38 +0000:
> Move (some of the) standalone types into separate implementation headers
> so that SVN++ can use them directly without exposing APR or other dependencies.

> +++ subversion/trunk/subversion/include/svn_opt_impl.h Fri Jan 4
> 10:38:53 2019
> @@ -0,0 +1,83 @@
> + * @file svn_opt.h
> + * @brief Option and argument parsing for Subversion command lines
> + * (common implementation)
> + */
> +
> +/* NOTE:
> + * This file *must not* include or depend on any other header except
> + * the C standard library headers.
> + */

Could the comment also explain the rationale for the restriction it imposes?

> +
> +#ifndef SVN_OPT_IMPL_H
> +#define SVN_OPT_IMPL_H
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif /* __cplusplus */

Cheers,

Daniel
Received on 2019-01-04 15:20:56 CET