On Fri, Dec 28, 2018 at 8:20 AM Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>
wrote:
> On 12/28/18 4:09 AM, Troy Curtis wrote:
> > LGTM, committed as r1849804, but without the unnecessary gymnastics to
> continue supporting str() in those two cases mentioned above. I also
> tweaked the log message to use complete sentences (and removed references
> to the code that I didn't include).
>
> Thank you for correct my broken log message.
>
> As the second step of follow up r1849784, I've fixed #if blocks usage
> in subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c because
> it is obvious and it doesn't contain any functional change.
>
> follow up r189784: fix macro usage to distinguish py2 and py3 context
>
> * subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
> Include "swigutil_py3c.h" file before define SVN_SWIG_BYTES_FMT to use
> IS_PY3 macro to switch py2 and py3 context
> (add_directory, add_file, apply_textdelta, change_file_prop,
> close_file, parse_fn3_set_revision_property,
> parse_fn3_set_node_property, svn_swig_py_notify_func,
> svn_swig_py_notify_func, svn_swig_py_delta_path_driver_cb_func,
> svn_swig_py_repos_authz_func, svn_swig_py_log_receiver,
> svn_swig_py_client_blame_receiver_func,
> svn_swig_py_changelist_receiver_func,
> svn_swig_py_auth_simple_prompt_func,
> svn_swig_py_config_auth_walk_func,
> ra_callbacks_get_wc_prop, ra_callbacks_push_or_set_wc_prop,
> ra_callbacks_invalidate_wc_props, svn_swig_py_commit_callback,
> reporter_set_path, reporter_link_path,
> wc_diff_callbacks2_file_changed_or_added,
> wc_diff_callbacks2_file_deleted, wc_diff_callbacks2_dir_added,
> wc_diff_callbacks2_dir_props_changed,
> svn_swig_py_config_enumerator2):
> Use IS_PY3 macro instead of comparison of PY_VERSION_HEX
> (add_directory, add_file, apply_textdelta, change_file_prop,
> close_file, parse_fn3_set_revision_property,
> parse_fn3_set_node_property, ra_callbacks_get_wc_prop,
> ra_callbacks_push_or_set_wc_prop, ra_callbacks_invalidate_wc_props):
> Enclose only format argument of Py_CallFunction or Py_CallMethod
> with #if IS_PY3 #else #endif block
>
Great! LGTM, committed as r1850011.
> Cheers,
> --
Yasuhito FUTATSUKI
>
Troy
Received on 2018-12-31 05:16:38 CET