Re: [swig-py3][patch] interfacing bytes object instead of str

Troy Curtis Jr wrote on Mon, Dec 24, 2018 at 22:20:40 -0500:
> On Mon, Dec 24, 2018 at 1:11 PM Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>
> wrote:
> @@ -1321,7 +1321,7 @@ svn_swig_py_unwrap_string(PyObject *source,
> > void *baton)
> >
>
> Requiring "source" to be a Bytes object, makes this function name be
> incorrect, since giving it a string will cause an error. Probably a
> reasonable place to support both Bytes/str. This is an exported function, so
> changing the name isn't a good option.

We don't promise ABI compatibility for all exported symbols; only for
those that are part of the public API. It's not clear to me that this
function qualifies: is it expected that anyone other than Subversion's
own code will call this function? After all, the header file that
declares it (swigutil_py.h) isn't even installed by install-swig-py.

If it doesn't qualify as a public API function, then we're free to
change its semantics however we wish, with or without renaming it (there
are precedents for both options).

Cheers,

Daniel
Received on 2018-12-25 16:37:48 CET