[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix use-after-free in mod_dav_svn's log_warning()

From: Stefan Sperling <stsp_at_elego.de>
Date: Tue, 18 Dec 2018 10:15:56 +0100

On Tue, Dec 18, 2018 at 03:55:42AM +0100, Stefan Fuhrmann wrote:
> Error handling during tear-down is always a bit messy.
>
> I guess not using the request struct will mean we cannot
> tell what operation cased a problem - ever (not sure,
> though). If true, that's a high cost.
>
> One way to improve your solution would be to make
> the error handling degrade as the objects are being
> destroyed. But it adds / duplicates a bit of code:
>
> * keep the logging based on request context
> * apr_pool_pre_cleanup_register on the request pool,
>   a switch to the new connection-based logging
>

That's a fair suggestion. I'll try to implement this.

This problem is blocking me from using httpd 2.4 in my builds (yes,
I should have upgraded this dependency a long time ago, I know...).
So if your suggestion turns out to be too complicated then I will
just go for my initial diff first and revisit this later.

> Greetings from CN!

Hah, sounds like you're having a great time :)
Received on 2018-12-18 10:16:12 CET

This is an archived mail posted to the Subversion Dev mailing list.