Re: svn commit: r1849080 - in /subversion/trunk/subversion: bindings/javahl/native/Path.cpp include/svn_dirent_uri.h libsvn_subr/dirent_uri.c svndumpfilter/svndumpfilter.c tests/libsvn_subr/dirent_uri-test.c

From: Julian Foad <julianfoad_at_apache.org>
Date: Mon, 17 Dec 2018 12:47:57 +0000

Branko Čibej wrote:
> >>>> (svn_relpath__internal_style): Change prototype so that the function can
> >>>> return an error instead of aborting if anything goes wrong.
> [...] I'll rename the function at the same time.

See IRC: I suggest a name like "svn_relpath__from_rel_dirent", and its use in JavaHL appears to be erroneous or at the very least error-prone.

-- 
- Julian

Received on 2018-12-17 13:48:05 CET

This message: [ Message body ]
Next message: futatuki_at_poem.co.jp: "Re: [swig-py3][patch] interfacing bytes object instead of str"
Previous message: Branko Čibej: "Re: svn commit: r1849080 - in /subversion/trunk/subversion: bindings/javahl/native/Path.cpp include/svn_dirent_uri.h libsvn_subr/dirent_uri.c svndumpfilter/svndumpfilter.c tests/libsvn_subr/dirent_uri-test.c"
In reply to: Branko Čibej: "Re: svn commit: r1849080 - in /subversion/trunk/subversion: bindings/javahl/native/Path.cpp include/svn_dirent_uri.h libsvn_subr/dirent_uri.c svndumpfilter/svndumpfilter.c tests/libsvn_subr/dirent_uri-test.c"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]