On 13.12.2018 16:42, Johan Corveleyn wrote:
> On Thu, Dec 13, 2018 at 4:05 PM Julian Foad <julianfoad_at_apache.org> wrote:
>> Johan Corveleyn wrote:
>>> Just thinking out loud here, but could we perhaps log the
>>> non-canonical value as part of the assertion output?
>>> [...]
>>> something like
>>>
>>> line 10238: assertion failed
>>> (svn_dirent_is_absolute(local_abspath='C:ImNotCanonical'))
>> Yes, Johan, we could do that.
>>
>> The attached patch demonstrates it working.
>>
>> Test output:
>> [[[
>> $ subversion/tests/libsvn_wc/wc-test 1
>> ...
>> svn_tests: E235000: In file '.../subversion/libsvn_wc/wc_db.c' line 10238: assertion failed (svn_dirent_is_absolute(local_abspath='C:ImNotAbsolute'))
>> ...
>> ]]]
> Nice :-). I'm not sure what others think, but IMHO that would make
> these error reports a lot more useful ...
Uh. I forgot about the malfunction handler. However this doesn't really
help, other than putting possibly sensitive paths into the crash handler
info? We really shouldn't do it this way, users *will* just copy and
paste the output tot he 'net.
-- Brane
Received on 2018-12-13 16:45:39 CET