[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fwd: [Daniel Shahaf: [PATCH] Re: [PATCH] A test for "Can't get entries" error]

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sun, 2 Dec 2018 08:28:24 +0000

Stefan Fuhrmann wrote on Sat, Dec 01, 2018 at 11:08:02 +0100:
> Yes, that does make sense. Thank you for fixing this.
>
> My mental image was: Stop at the last parent level (re-usable
> between siblings) and attempt a leaf lookup, which would then
> handle the error cases. This is obviously incomplete for the
> case that the parent is not a directory but has been cached.
>
> What I do not understand, yet, is why this has not been
> reported earlier and why it is not present in FSX. I plan to dive
> into that code tonight and come back with the result.

Thanks, Stefan.

To avoid misunderstanding, please note that I haven't committed this
patch yet, and that kotkov has committed a different fix in r1847572.
I assume the patch I posted is still applicable, though, as it fixes
a (now latent) bug in the for(;;) loop.

Cheers,

Daniel
Received on 2018-12-02 09:28:40 CET

This is an archived mail posted to the Subversion Dev mailing list.