[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] A test for "Can't get entries" error

From: Julian Foad <julianfoad_at_apache.org>
Date: Fri, 30 Nov 2018 12:28:48 +0000

Julian Foad wrote:
> https://issues.apache.org/jira/browse/SVN-4791

This issue appears to be closely related to issue #SVN-4677. The fix applied in r1847572 is an extension of the fix applied in r1795116 for SVN-4677.

Reviewed, tested and nominated for backport to 1.11, 1.10, 1.9.

Daniel Shahaf wrote:
> Julian Foad wrote:
> > [...] I attach a patch that backports the initial RA-level test to 1.8. 1.9 and 1.10.
> Any reason not to commit that one, too?

No particular reason not to commit that, I suppose.

Really I'd prefer that we would put more effort into randomized testing. A single test could cover this particular sequence as well as many others.

In the absence of that ... Could do. No strong feeling. In one sense, extra regression tests are better ... but in another sense, more are clutter. I think in this case, as it seems the underlying cause is fixed and tested, I won't, but am fine with someone else doing so.

- Julian
Received on 2018-11-30 13:28:56 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.