Re: [swig-py3][patch] interfacing bytes object instead of str

Yasuhito FUTATSUKI wrote on Thu, 22 Nov 2018 20:16 +0900:
> Now ViewVC (un-official branch) works with swig-py on py3 :-)
> (https://github.com/futatuki/viewvc/tree/python3_support_with_altsvn)

Ah, so _that's_ why Mike asked about py3 support the other day :-)

> By the way, while I've read headers, I found some other APIs handle
> 'eol' argment, in svn_subst.h and svn_diff.h. I think some of them
> might need to handle some argment as bytes, because str on py3 normalize
> eol style.

Thanks for the patch. I'm afraid I'm a bit disoriented, though; could
you kindly clarify a few things?

Is the patch destined for trunk, for branches/swig-py3_at_HEAD, or for
branches/swig-py3 after a sync-merge from trunk? Does it replace your
previous patch, or are the two patches meant to be applied on top of
each other? How do we test the patch to see the problem that it
corrects --- I assume that we should just run check-swig-py in a py3
build and see that it has fewer failures with the patch than without; is
that correct?

Thanks,

Daniel
Received on 2018-11-23 03:28:57 CET