Re: [PATCH] Re: [PATCH] A test for "Can't get entries" error

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 22 Nov 2018 01:11:00 +0000

Daniel Shahaf wrote on Thu, 22 Nov 2018 00:51 +0000:
> While we're at this function, does anyone understand why directory[1] is
> accessed without checking whether directory[0] is not NUL? There is
> a comment there, but it doesn't enlighten me. (However, I haven't run
> 'blame' on that comment yet.) Even if it's correct, is there any reason
> not to add an SVN_ERR_ASSERT(directory[0]) there?

Sorry, that's not quite the issue. directory[0] is almost certainly '/', and
that's a fundamental enough aspect of canonical paths that we shouldn't
need to assert it everywhere; but I'm still not certain what
.
/* root nodes are covered anyway */
.
means.

Cheers,

Daniel
Received on 2018-11-22 02:11:09 CET

This message: [ Message body ]
Next message: Yasuhito FUTATSUKI: "Re: [swig-py3][patch] interfacing bytes object instead of str"
Previous message: Daniel Shahaf: "Re: [swig-py3][patch] interfacing bytes object instead of str"
In reply to: Daniel Shahaf: "Re: [PATCH] Re: [PATCH] A test for "Can't get entries" error"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]