[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1846237 - /subversion/trunk/subversion/tests/cmdline/pegrev_parse_tests.py

From: Branko Čibej <brane_at_apache.org>
Date: Sun, 11 Nov 2018 07:52:55 +0100

On 11.11.2018 07:47, Branko Čibej wrote:

> Our usage of @ in paths may be
> well-defined too, but its interaction with aggressive canonicalization
> creates unintentional side effects in the implementation.

A really educational example of this is svn_cl__copy. It goes out of its
way to ignore a specific kind of peg-revision parsing error. I'm having
a really hard time trying to convince myself that can be the right thing
to do. If one particular command has to try to fix parsing errors in
order to work correctly, then I'd say that the parser is just wrong.

-- Brane
Received on 2018-11-11 07:53:04 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.