[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Coredump when javahl SVNClient::diff() called with diff-cmd set

From: Branko ─îibej <brane_at_apache.org>
Date: Thu, 1 Nov 2018 09:40:37 +0100

On 29.10.2018 16:36, matthew.burt_at_nats.co.uk wrote:
> Prevent some coredumps when using JavaHL SVNClient::diff()
>
> SVNClient::diff() discards output to stderr by setting stderr parameters to NULL in some calls
>
> Some of the called code can dereference the NULL in some situations. One
> such situation is if the user has set a diff-cmd value in their settings file.
>
> The documented interface to relevant routines does not say that stderr can be set to NULL in this way.
>
> Observed in the 1.10.3 client
>
> * subversion/bindings/javahl/native/SVNClient.cpp
>
> (SVNClient::diff): Replace NULL stderr in calls to (deprecated) svn_client_diff_peg6()
> and svn_client_diff6() with svn_stream_empty objects.

Thanks, committed in r1845408, and I'll propose this for backports to
1.10.x and 1.11.x.

-- Brane
Received on 2018-11-01 09:40:47 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.