On 2018/10/30 21:11:57, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> Ruediger Pluem wrote on Tue, Oct 30, 2018 at 19:57:58 -0000:
> > BTW, I had to apply the following patch to nominate.pl to get it running with perl 5.16.3 on CentOS 7:
> >
> > Index: tools/dist/backport.pl
> > ===================================================================
> > --- tools/dist/backport.pl (revision 1845203)
> > +++ tools/dist/backport.pl (working copy)
> > @@ -791,8 +791,8 @@
> >
> > # Add to state votes that aren't '+0' or 'edit'
> > $state->{$_->{digest}}++ for grep
> > - ($_->{approval} or $_->{vote} =~ /^(-1|-0|[+]1)$/),
> > - @votesarray;
> > + (($_->{approval} or $_->{vote} =~ /^(-1|-0|[+]1)$/),
> > + @votesarray);
> > }
> > }
> >
> > I am happy to commit this if this is fine with later versions of perl which I have not at hand for testing.
>
> Works for me with and without the change, Perl 5.24.1 on Debian stretch.
> +1 to commit.
>
> Consider using «grep +(foo), @bar» or «grep { foo } @bar» instead of
> «grep ((foo), bar»: the three alternatives are equivalent, so it's just
> a question of which one is more readable/idiomatic.
Used the grep +(foo), @bar syntax and committed in r1845312
Regards
Rüdiger
Received on 2018-10-31 07:49:48 CET