[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 'svn info --viewspec' has an if (TRUE)

From: Julian Foad <julianfoad_at_apache.org>
Date: Mon, 17 Sep 2018 20:39:39 +0100

Daniel Shahaf wrote:
> From subversion/svn/info-cmd.c:
> 272 if (TRUE)
> 274 /* svn-viewspec.py format */
> 281 else
> 283 /* svn command-line format */
> Why is there an «if (TRUE)» there? Should that condition be exposed a
> command-line option, or removed?

For experimenting with viewspec output, I feel both formats are about equally useful at this stage, neither is ideal, and neither is likely what an eventual stable format should be. That's based on knowing that cmdline is practical for testing and assuming that there are some users using viewspec.py (e.g. Paul Hammant recently contributed a regression test suite for it).

I was thinking to add a cmdline option to select, for the time being. IIRC Brane said "pick one and be done with it". That's as far as we got. I still favour adding a user-selectable option, e.g. "--x-viewspec={cmdline|svn-viewspec.py}" (ugly, I know).

- Julian
Received on 2018-09-17 21:39:48 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.