Re: 'svn info --viewspec' has an if (TRUE)

Daniel Shahaf wrote:
> From subversion/svn/info-cmd.c:
> 272 if (TRUE)
> 274 /* svn-viewspec.py format */
> 281 else
> 283 /* svn command-line format */
>
> Why is there an «if (TRUE)» there? Should that condition be exposed a
> command-line option, or removed?

For experimenting with viewspec output, I feel both formats are about equally useful at this stage, neither is ideal, and neither is likely what an eventual stable format should be. That's based on knowing that cmdline is practical for testing and assuming that there are some users using viewspec.py (e.g. Paul Hammant recently contributed a regression test suite for it).

I was thinking to add a cmdline option to select, for the time being. IIRC Brane said "pick one and be done with it". That's as far as we got. I still favour adding a user-selectable option, e.g. "--x-viewspec={cmdline|svn-viewspec.py}" (ugly, I know).

-- 
- Julian