Re: FSFS recovery should prune rep-cache even if its use is disabled

Daniel Shahaf wrote:
> Julian Foad wrote on Thu, Aug 23, 2018 at 10:21:17 +0100:
> > +++ subversion/libsvn_fs_fs/recovery.c (working copy)
> > @@ -468,15 +468,15 @@ recover_body(void *baton, apr_pool_t *po
> > /* Prune younger-than-(newfound-youngest) revisions from the rep
> > - cache if sharing is enabled taking care not to create the cache
> > - if it does not exist. */
> > - if (ffd->rep_sharing_allowed)
> > + cache, no matter whether sharing is currently enabled, taking care
> > + not to create the cache if it does not exist. */
> > + if (ffd->format >= SVN_FS_FS__MIN_REP_SHARING_FORMAT)
>
> Looks good to me: that should fix both #4077 and #4214.

Committed in http://svn.apache.org/r1838813

I added tests there for both cases (enabled, disabled).

> I would only suggest expanding the comment [...]

Looks good to me, so I included your text.

Thanks.
- Julian
Received on 2018-08-24 12:52:22 CEST