FSFS recovery should prune rep-cache even if its use is disabled
From: Julian Foad <julianfoad_at_apache.org>
Date: Wed, 22 Aug 2018 22:16:43 +0100
It looks like r1213716 ("also prune the rep-cache when it's present but reportedly not being used") was reverted by r1367674, apparently unintentionally.
https://svn.apache.org/r1213716 (on 2011-12-13)
https://svn.apache.org/r1367674 (on 2012-07-31)
The function concerned, recover_body(), has since been moved to subversion/libsvn_fs_fs/recovery.c.
If "recovery" while re-sharing is disabled (by the fsfs.conf setting) leaves future revision entries in the rep-cache, then later re-enabling the rep-cache could cause serious corruption if those entries are then used.
Therefore I think we should repeat r1213716 as a bug fix.
-- - JulianReceived on 2018-08-22 23:16:51 CEST
This is an archived mail posted to the Subversion Dev mailing list.