Re: Using delta editor to read and write WC local mods

Julian Foad wrote:
> ra_serf/update.c
> - uses copyfrom to select a base file version for delta
> - passes any copyfrom through to the update editor
> - the update editor asserts that no copyfrom shall ever arrive
> (svn_wc__get_update_editor/svn_wc__get_switch_editor)
[...]
> svn_repos_begin_report3(send_copy_from_args=True):
> - sends copyfrom to editor->add_file(),
> - for files only (in "add_file_smartly()"),
> - only when the file itself was the copy root.
[...]
> No current caller of svn_ra_do_update|switch requests sending copyfrom.
> If any third-party code does, it only gets copyfrom in very limited
> cases. So,
> -> can the 'send_copy_from_args' option be deprecated, server-side?

It could be deprecated but not removed, in order to keep backward compatibility.

> -> this API option should be deprecated, client-side;

The API could be 'revved', leaving the option in the deprecated version.

> -> the ra_serf update code using copyfrom should be removed
> (following r998193 which removed its last use)

I removed that code in http://svn.apache.org/r1837289 but restored it in r1837290 for backward compatibility with library users that are driving a different update editor.

-- 
- Julian