[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: authz changes between 1.9 and 1.10

From: Philip Martin <philip_at_codematters.co.uk>
Date: Tue, 24 Jul 2018 23:37:06 +0100

Branko Čibej <brane_at_apache.org> writes:

> On 20.07.2018 14:59, Philip Martin wrote:
>> In 1.9 it was possible to repeat, or reopen, a section:
>
> It's an intentional change that is documented in the design wiki page.

And only there, it didn't make the release notes.

>> In 1.9 any repeat acl lines that were the exact same match, such as:

> This is also documented in the design page (Inheritance and
> Disambiguation, item 8).

But not explicitly as a change from 1.9, and again not in the release
notes.

>> Finally, issue 4762. In 1.9 if both global and per-repository sections
>> matched they were combined, so:
>
> See Inheritance and Disambiguation, items 6 and 7:  "If
> repository-specific path rules as well as global path rules match a
> given path, only the repository-specific ones will be considered." and
> "If multiple path rules match a given repository path, only the one
> specified last in the authz file shall apply."
>
> So this is as designed. If this is a design bug, I wish someone had
> pointed it out a few years ago ...

Again, it's not explicitly documented as a change from 1.9 and it's not
in the release notes.

> It describes designed behaviour. If we change it, we should do it
> carefully, as I wrote above. Also I think it turns out that the authz
> section in the release notes misses a behaviour change or two. It should
> probably include the whole Inheritance and Disambiguation list, however
> we end up changing it.

The most important thing is to document the change in behaviour of the
non-glob rules between 1.9 and 1.10.

The problem I have is that I still don't know if the changes are
intentional. Of these undocumented (in the release notes) changes there
is one that appears to be intentional and two that could be accidental.
At least the first, intentional, change produces a run-time error if it
occurs, the other two just lead to different access being granted, one
less access the other more access. Anyone using a non-trivial authz
file in 1.9 has to be very careful upgrading to 1.10.

Is it worth me working on a fix? Can we declare 1.10.0 and 1.10.1 buggy
and change the behaviour in future 1.10.x? Or are we stuck with 1.10
being different from 1.9?

-- 
Philip
Received on 2018-07-25 00:37:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.