Re: Directory becomes file when applying patch
From: Julian Foad <julianfoad_at_apache.org>
Date: Mon, 16 Jul 2018 16:24:52 +0100
Dmitry Pavlenko wrote:
Thank you for testing and finding these issues, Dmitry!
> Here I provide a reproducing script and also add a file for comparison.
That line is not distinguishing between file-kind and dir-kind, it is just telling the name of the file/dir.
> b) "new file mode 10644" for file and no such line for directory;
That line is the right information to use. (If we ever want a mode line for a directory, it can say "new directory ..." instead of "new file ...".)
> I don't know whether it's a known issue or not but I think it would be nice to
It is not useful to add "probably" logic when there is a possibility to use exact logic.
Can you please file an issue and turn your script into a regression test?
Is there any chance you may be able to work on fixing these after you finish testing? I do hope somebody will.
-- - JulianReceived on 2018-07-16 17:25:00 CEST
This is an archived mail posted to the Subversion Dev mailing list.