[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Subversion 1.10.2 up for testing/signing

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 16 Jul 2018 06:52:49 +0000

Johan Corveleyn wrote on Mon, 16 Jul 2018 00:46 +0200:
> It seems something went wrong with the "Post-release housekeeping"
> commits on the 1.10.x branch, r1835806 (post 1.10.1) and r1835936
> (post 1.10.2): they contain an empty diff for svn_version.h ... weird.

An empty diff is the result of an 'svnmucc put' that didn't change the
file. (As in, 'svn revert iota; svnmucc put iota iota')

What happened is, in r1935935 STATUS said "Status of 1.10.2:" and
svn_version.h said "#define SVN_VERSION_PATCH 0"; then release.py
changed "2" to "3" on both of these lines. That effected the correct
change to STATUS and no change to svn_version.h.

The thing is, replace_in_place() has a 'raise RuntimeError' statement
designed to catch precisely this situation. I don't understand why it
didn't fire.

Julian, just to double check, you rolled 1.10.2 using the trunk version of
release.py, right?

Cheers,

Daniel
Received on 2018-07-16 08:53:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.