[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1834612 - in /subversion/branches/1.10.x-issue4758/subversion: libsvn_client/shelve.c tests/cmdline/shelve_tests.py

From: Philip Martin <philip_at_codematters.co.uk>
Date: Fri, 13 Jul 2018 16:36:05 +0100

Julian Foad <julianfoad_at_apache.org> writes:

> Philip, can you help clarify this?
>>
>> It's not clear to me from the added paragraph whether the restriction
>> "only access the context from a thread at a time" is imposed by the
>> library implementation or by the way API consumers' code is typically
>> structured. That is: if a client is careful to use mutexes in his
>> batons, or for that matter passes NULL for all batons, would the
>> restriction still apply?

Look at repos_to_wc_copy_single() for example: it stores the original
notify func/baton, sets temporary values, then restores the original
values. I think it is clear that only works if the context is for
single thread, even if the func/batons are NULL.

-- 
Philip
Received on 2018-07-13 17:36:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.