Re: svn commit: r1834612 - in /subversion/branches/1.10.x-issue4758/subversion: libsvn_client/shelve.c tests/cmdline/shelve_tests.py
From: Julian Foad <julianfoad_at_apache.org>
Date: Mon, 02 Jul 2018 12:20:11 +0100
There are three issues here:
Philip Martin wrote:
There are four other places where libsvn_client functions modify ctx in place. They are all modifying the notification callback, with the following pattern:
To solve that problem I will use the same pattern as above.
r1834835, added to backport nomination in r1834836.
Note that this fix is for the 1.10.x branch only, as this bit of shelving code doesn't exist on trunk.
> I did also worry about thread safety: it's not safe to modify the
Documenting that sounds reasonable. Like this, just above typedef struct svn_client_ctx_t, do you think?
>> Bert Huijben writes:
That seems like the correct form of solution, in general.
In this case, however, the only reference to 'ctx->config' in the whole of libsvn_client/diff.c is passing it to create_diff_writer_info() to configure an external diff tool, and I don't think it is used by any called functions either.
So I think this is OK as it is.
This is an archived mail posted to the Subversion Dev mailing list.