Re: shelf-tests failure on macOS

Philip Martin wrote on 2018-06-14:
> Philip Martin <philip_at_codematters.co.uk> writes:
> > Julian Foad <julianfoad_at_apache.org> writes:
> >> The most unusual thing about these failing tests is the data they
> >> write. Strings of 5 or 6 low-value bytes, like:
> >>
> >> '\0\1\2\3\4\5'
> >> '\5\4\3\2\1\0'
> >
> > Those are the same size. Could it be a filesystem timestamp resolution
> > issue? The file changes but the timestamp does not and some change is
> > not detected?
>
> An HFS+ filesystem has a coarse 1s timestamp resolution so that would
> explain why the problem shows up there but not systems with subsecond
> resolution.

Sounds like the correct explanation.

> Neither shelve or unshelve appear to use svn_sleep_for_timestamp().

Actually shelve already does, in the relevant code path, which is inside svn_client_shelf_unapply() where it uses svn_client_revert4() which does.

Unshelve sleeps now, since r1833532. Hopefully that's the end of it.

Thank you very much for the insight, Philip!

- Julian
Received on 2018-06-14 19:35:14 CEST