[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: handling of reparse points

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 25 May 2018 17:37:34 +0200

Can anyone comment on this please?

On Fri, May 18, 2018 at 10:29 PM Stefan Kueng <tortoisesvn_at_gmail.com> wrote:

> Hi,
>
> It seems that svn doesn't handle reparse points properly in all
> situations. Which causes big problems for TSVN when a working copy is on
> a Onedrive folder.
>
> See here for more details:
> https://groups.google.com/d/msg/tortoisesvn/hlQj5OifhBg/RX_cw_sQCgAJ
>
> While in this particular situation, other svn clients are not affected,
> it still means that there's a problem.
>
> I've attached a patch for handling reparse points better when detecting
> and reading the working copy database. With this change, the TSVN
> context menu shows up properly.
>
> But while I was trying to figure out this particular problem I noticed
> that svn_io_check_path() never tries to resolve the reparse points. Why
> is that? I mean if we need to check for links/reparse-points there's
> svn_io_check_special_path(). Also, svn_io_check_path() always returns
> node_file for reparse points, even if they point to directories.
> IMHO handling links/reparse-points specially is only required in very
> specific situations, like adding them. In most cases, resolving the
> links/reparse points is what should be done. Or am I missing something
> big here?
>
> Stefan
>

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
Received on 2018-05-25 17:37:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.