[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1831540 - /subversion/trunk/subversion/tests/cmdline/svntest/main.py

From: Branko ─îibej <brane_at_apache.org>
Date: Mon, 14 May 2018 09:35:36 +0200

On 14.05.2018 08:54, jorton_at_apache.org wrote:
> Author: jorton
> Date: Mon May 14 06:54:55 2018
> New Revision: 1831540
>
> URL: http://svn.apache.org/viewvc?rev=1831540&view=rev
> Log:
> * subversion/tests/cmdline/svntest/main.py
> (open_pipe): Run Python tests under the same Python executable for
> all platforms rather than just Win32 (rather than finding one from
> $PATH via /usr/bin/env).
>
> Reviewed by: brane
>
> Modified:
> subversion/trunk/subversion/tests/cmdline/svntest/main.py
>
> Modified: subversion/trunk/subversion/tests/cmdline/svntest/main.py
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/svntest/main.py?rev=1831540&r1=1831539&r2=1831540&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/tests/cmdline/svntest/main.py (original)
> +++ subversion/trunk/subversion/tests/cmdline/svntest/main.py Mon May 14 06:54:55 2018
> @@ -456,9 +456,9 @@ def open_pipe(command, bufsize=-1, stdin
> should be passed to wait_on_pipe."""
> command = [str(x) for x in command]
>
> - # On Windows subprocess.Popen() won't accept a Python script as
> - # a valid program to execute, rather it wants the Python executable.
> - if (sys.platform == 'win32') and (command[0].endswith('.py')):
> + # Always run python scripts under the same Python executable as used
> + # for the test suite.
> + if command[0].endswith('.py'):
> command.insert(0, sys.executable)
>
> command_string = command[0] + ' ' + ' '.join(map(_quote_arg, command[1:]))

Can you please propose this and related changes you made for backport to
1.10.x?

Thanks!

-- Brane
Received on 2018-05-14 09:35:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.