[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fixed python executable for svntest

From: Branko ─îibej <brane_at_apache.org>
Date: Tue, 8 May 2018 12:31:55 +0200

On 08.05.2018 12:19, Joe Orton wrote:
> As part of the Python 2->3 migration effort in Fedora we've been trying
> to get to the point where setting PYTHON=/usr/bin/python3 allows us to
> ensure that /usr/bin/python is never used in the build environment.
>
> One thing that doesn't work right with svn is that the test scripts are
> run by executing shebang scripts with "#!/usr/bin/env python", which
> means the PYTHON variable set in make is ignored. This is trivial to fix
> by adopting the same logic as used for Win32 already.
>
> Are there any objections to doing this?
>
> [[[
> * subversion/tests/cmdline/svntest/main.py
> (open_pipe): Run Python tests under the same Python executable for
> all platforms rather than just Win32 (rather than finding one from
> $PATH via /usr/bin/env).
> ]]]
>

Looks good to me, +1.

-- Brane
Received on 2018-05-08 12:32:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.