On 15.04.2018 23:42, Stefan wrote:
> On 15/04/2018 22:56, Julian Foad wrote:
>> Branko Čibej wrote on 2018-04-15:
>>> On 15.04.2018 21:01, Stefan wrote:
>>>> On 05/04/2018 00:09, Stefan wrote:
>>>>> I'm not sure if there are other tools around using these. I'm talking
>>>>> here TSVN which utilizes all of these properties and yes, it's treating
>>>>> them as inheritable ones. There seem to be other tools using these as
>>>>> well [1/2], though I can't say for sure whether they are treating them
>>>>> as inheritable (though I'd strongly suspect so).
>>>>> https://markphip.blogspot.de/2007/01/integrating-subversion-with-your-issue.html
>> Mark's blog post there says the spec was developed jointly with Subclipse so that's at least one other.
>>
>> Did you (Stefan) check inheritance works as expected?
> I know for sure that it's working for TSVN (that's the way I set
> things up at our company). I don't have Subclipse available however,
> so can't check it there.
>> The spec at
>>
>> http://tortoisesvn.tigris.org/svn/tortoisesvn/trunk/doc/issuetrackers.txt
>>
>> (give the username 'guest' and no password to access it) says:
>>
>> - If the properties are not set for a folder, the client should search upwards
>> in the working copy for them until the working copy root is reached.
>>
>> It doesn't say the client will search up into a parent folder in the repository that isn't in the WC.
>>
>> That suggests your change may break quite a lot of use cases unless the info I found above is out of date.
> I'll check with Stefan to make things either made more clear or
> removed (if outdated meanwhile, which to me this phrase looks like) in
> the docu. Note that the actual user documentation is usually more
> up-to-date and with regards to the property handling also states: "As
> of version 1.8, TortoiseSVN and Subversion use so called |inherited
> properties|, which means a property that is set on a folder is
> automatically also implicitly set on all subfolders. So there's no
> need to set the properties on all folders anymore but only on the root
> folder." [1]
> While this is not 100% clear here that "folder" in this regards is no
> longer limited to the WC checkout root, this is actually what is meant
> here, as far as I'm aware.
>
> And just to be 101% sure: I just double checked with current SVN trunk
> where the props were already removed. TSVN works there as expected.
> All the properties I moved to the subversion root are listed as
> inherited props.
>> If I have misunderstood something, then the Subversion feature "Inheritable properties" may possibly have made this "Just work", possibly; but I don't think so; but at least that feature should make it much easier to implement inheritance that searches up beyond the WC root to a folder that's only in the repository, if/when the various clients choose to do so.
>>
>>> Tags should not change.
>>> +1 for removing those properties from branches.
>> That part I agree with.
>>
>> - Julian
> I'm not going to make a case out of this, but please be aware the
> implications of keeping the incorrect/outdated props on the tags:
> - checkout the 1.9.0 tag
> - bring up the TSVN log dialog of the WC
> - select r1689313 (which has a reference to issue 4582 f.e.)
> - click the linked issue -> brings up the old tigris issue tracker
> instead of the JIRA one:
> http://subversion.tigris.org/issues/show_bug.cgi?id=4582
> - right click an entry in the TSVN log dialog -> select "View revision
> in webviewer" -> brings up the http-link (instead of the https-link -
> while "View revision for path in webviewer" leads to the https-URL)
Note that if a user wants to dig in to solved issues, they can get the
same info from release branches as from release tags. And since we all
agree about removing the properties from branches, inheritance will work
as expected. New release tags will not have those properties, either.
-- Brane
Received on 2018-04-16 00:09:13 CEST