[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: release.py create-tag failed to update STATUS

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sat, 14 Apr 2018 17:27:46 +0000

Julian Foad wrote on Sat, 14 Apr 2018 18:21 +0100:
> Daniel Shahaf wrote on 2018-04-14:
> > > It's because it uses "svnmucc -r <REV> put <...>" but STATUS has already been modified between r<REV> and HEAD.
> >
> > Agreed. It's perfectly possible for the branch to have changed between the
> > magic revision and HEAD. When editing STATUS, the base revision (argument to
> > the -r option) should be HEAD resolved to a number.
> >
> > Something like this, perhaps?
> I agree the semantics you propose is/are correct. The patch looks right,
> inspecting the diff; I haven't tested it.

Neither have I.

Thanks for the review. I've gone ahead and committed the patch. (It's
probably correct and unlikely to worsen the situation.)


Received on 2018-04-14 19:27:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.