[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Warnings from the bindings

From: Philip Martin <philip_at_codematters.co.uk>
Date: Sat, 07 Apr 2018 20:20:54 +0100

Branko Čibej <brane_at_apache.org> writes:

> I'll take another look. At the very least this should be using the local
> frame manager object, which is exception-safe, unlike explicitly pushing
> and popping the frame.

ImmutableList::for_each iterates and constructs arbitrary types T. The
problem occurs when T is ExternalItem as the constructor generates local
refs from the get_string_field and get_revision_field calls. It's
possible that we should modify ExternalItem to avoid doing this, but
for_each should also work with arbitrary types and so for_each should
use a local frame. I've comitted the for_each change.

Received on 2018-04-07 21:21:03 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.