Re: swig-py3 svn_stream_read

Troy Curtis Jr wrote on Fri, Mar 23, 2018 at 11:09:42 +0000:
> On Fri, Mar 23, 2018, 3:10 AM Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> > — shouldn't svn_stream_read() return bytes under py3?
> >
>
> Yes, I would say that bytes is absolutely the right thing to return here
> since svn_stream is an arbitrary byte interface.
>

Okay. I haven't looked too deeply but I think that might fix those test
failures (and possibly cause a bunch of others…). I went ahead and added
it to BRANCH-README in r1827665.

> I seem to remember thinking the tests weren't going to work on the swig-py3
> branch out-of-the-box, but I would be lying if I said I could remember the
> details of what I was thinking!

No worries. Next time you might put your thoughts in a Subversion repository
or something so they wouldn't be lost. :-)

Cheers,

Daniel
Received on 2018-03-24 20:31:09 CET