[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Testsuite options

From: Philip Martin <philip_at_codematters.co.uk>
Date: Mon, 19 Mar 2018 13:29:39 +0000

Philip Martin <philip_at_codematters.co.uk> writes:

> It is even more pointless than that. Looking at the code in
> svn_fs_fs__initialize_caches() I see that revprop caching is now enabled
> unconditionally for all FSFS access.
> The config setting SVN_FS_CONFIG_FSFS_CACHE_REVPROPS is public in
> svn_fs.h so it has to remain for backward compatibility. The
> mod_dav_svn SVNCacheRevprops apache directive also still exists.
> svnserve still has the --cache-revprops command line option.
> Oddly, we still have code in mod_dav_svn.c and svnserve.c that responds
> to the directive/option setting and changes the setting of
> SVN_FS_CONFIG_FSFS_CACHE_REVPROPS in the config hash. That's pointless
> as there is no FSFS code that responds to that config setting.
> I suppose the mod_dav_svn directive and svnserve command line option
> have to remain for backward compatibility, but why do we retain the code

I didn't realise that revprop caching had changed for 1.10, and since it
isn't mentioned in the release notes I guess that applies to other
people as well.


  SVNCacheRevprops on

in apache config is now a no-op, while setting

  SVNCacheRevprops off

is silently ignored. Similarly, the command line option

  svnserve --cache-revprops on

is a no-op, and the command line option

  svnserve --cache-revprops off

is silently ignored.

Is documenting this change in the release notes sufficient? Should 1.10
raise a warning/error if the user makes a futile attempt to disable
revprop caching?

Received on 2018-03-19 14:29:51 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.