fsfs 'structure' terminology: length/size v. size/expanded-size (was: Re: E130003: The XML response contains invalid XML - Follow-up)

[ cc += dev@ ]

NOCERA, ANDY wrote on Thu, 15 Mar 2018 22:35 +0000:
> Folks,
>
> I used dump and load to debug the malformed node revision ID. Here are
> my steps and what learned. Looks like the revs' file text: entry has
> a zero instead of size.

To be clear, you mean the fourth field. On line 562 'size' is the name
of the fourth field but on line 119, and in the representation_t struct,
'size' is the name of the third field.[1]

This is a recipe for confusion. Normally I think of the fields using
the size/expanded-size terminology so I propose to change 'structure' to
use that terminology in lieu of length/size (and leave a note behind
pointing out that old versions of the document used <size> differently).

WDYT?

Daniel

[1] All line numbers refer to subversion/libsvn_fs_fs/structure.

> diff db/revs/0/1 /usr/tmp/xrepox/db/revs/0/1
> 18c18
> < text: 1 76 48 0 ec69809945c46f2bb74e99a3ff7cd917
> ---
> > text: 1 76 48 48 ec69809945c46f2bb74e99a3ff7cd917
> 22c22
Received on 2018-03-16 12:28:32 CET