[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1826864 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/layout.c svn/cl.h svn/info-cmd.c svn/svn.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Fri, 16 Mar 2018 06:28:23 +0000

Good morning Julian,

julianfoad_at_apache.org wrote on Thu, 15 Mar 2018 20:43 +0000:
> Author: julianfoad
> Date: Thu Mar 15 20:43:30 2018
> New Revision: 1826864
> URL: http://svn.apache.org/viewvc?rev=1826864&view=rev
> Log:
> Viewspec: Add an experimental viewspec output command.
> This reports the current layout of the working copy, in terms of switched
> URLs, mixed revisions, and mixed depths.
> The current CLI command is:
> svn info --viewspec [PATH]
> The current output is in the form of a series of 'svn' commands which can
> be used as command-line input to recreate the layout, although the behaviour
> when doing so is not optimal.
> Patch by: rhuijben
> (tweaked by me)
> * subversion/include/svn_client.h
> (svn_client_layout_func_t,
> svn_client_layout_list): New.
> * subversion/libsvn_client/layout.c
> New file.

This commit caused the svn-warnings bot to change from state PASS
(green) to WARNINGS (yellow) with the following diagnostics:

./subversion/include/svn_error.h:371:32: warning: call to ‘svn_client_layout_list’ declared with attribute warning: experimental function used
cc1: warning: unrecognized command line option ‘-Wno-unused-const-variable’

I appreciate that you said on IRC that the code intentionally calls an
experimental function. However, leaving the bot yellow would make it
useless, as future warnings would not be as visibly reported. Moreover,
the build should be warning-free (so developers can catch new warnings).

Can we find a way to both call the new function and have the build (on
the bot and on developer machines) warning-free?


Received on 2018-03-16 07:28:36 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.