[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svnadmin load error with 1.10 that seems to be fsfs cache related

From: Julian Foad <julianfoad_at_apache.org>
Date: Thu, 15 Mar 2018 18:06:46 +0000

Philip Martin wrote:
> cached_data.c:parse_raw_window() where the svndiff version is hard-coded
> to 1 in the call to svn_txdelta_read_svndiff_window. Changing that to 2
> allows the regression test to pass, the question is where should the
> correct value be obtained?

The simple answer appears to be 'rs->ver' (where 'rs' needs to be passed
in via the function's baton).

But does that mean this code isn't being tested by any of our manual or
buildbot testing in the last 6 months?

If so, we need to resolve that somehow before I am happy to release it.

Extending our testing is one option. I would much prefer to apply the
principle of testable design: "if this code only runs sometimes, change
it so it runs always". Can we do that?

- Julian
Received on 2018-03-15 19:06:49 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.