Mattias Engdegård wrote:
> 13 mars 2018 kl. 10.30 skrev Julian Foad <julianfoad_at_apache.org>:
>> For these issues of paragraph length, I invite you to edit the source text directly and make it nice.
>
> I'll postpone that for later if you don't mind.
Sure.
>>> * stats() in shelf-cmd.c isn't very translator-friendly:
>>> [...] would benefit from using gettext plurals. That's what it's there for!
>>
>> OK, done throughout 'shelve-cmd.c' in http://svn.apache.org/r1826614 and 'auth-cmd.c' in http://svn.apache.org/r1826617 . I invite you to do the same in other files.
>
> Thank you. These were the ones I could find right away:
>
> [[[
> Index: subversion/libsvn_client/conflicts.c
> ===================================================================
> --- subversion/libsvn_client/conflicts.c (revision 1826702)
> +++ subversion/libsvn_client/conflicts.c (arbetskopia)
> @@ -5944,8 +5944,11 @@
> {
> if (i == edits->nelts - (max_revs_to_display / 2))
> s = apr_psprintf(result_pool,
> - _("%s\n [%d revisions omitted for "
> - "brevity],\n"),
> + Q_("%s\n [%d revision omitted for "
> + "brevity],\n",
> + "%s\n [%d revisions omitted for "
> + "brevity],\n",
> + num_revs_to_skip),
> s, num_revs_to_skip);
>
> s = apr_psprintf(result_pool, _("%s r%ld by %s%s"), s,
> Index: subversion/libsvn_client/patch.c
> ===================================================================
> --- subversion/libsvn_client/patch.c (revision 1826702)
> +++ subversion/libsvn_client/patch.c (arbetskopia)
> @@ -343,7 +343,9 @@
> components = svn_path_decompose(path, scratch_pool);
> if (strip_count > components->nelts)
> return svn_error_createf(SVN_ERR_CLIENT_PATCH_BAD_STRIP_COUNT, NULL,
> - _("Cannot strip %u components from '%s'"),
> + Q_("Cannot strip %u component from '%s'",
> + "Cannot strip %u components from '%s'",
> + strip_count),
> strip_count,
> svn_dirent_local_style(path, scratch_pool));
>
> Index: subversion/libsvn_wc/props.c
> ===================================================================
> --- subversion/libsvn_wc/props.c (revision 1826702)
> +++ subversion/libsvn_wc/props.c (arbetskopia)
> @@ -2236,7 +2236,9 @@
> if (duplicate_targets->nelts > 1)
> {
> more_str = apr_psprintf(/*scratch_*/pool,
> - _(" (%d more duplicate targets found)"),
> + Q_(" (%d more duplicate target found)",
> + " (%d more duplicate targets found)",
> + duplicate_targets->nelts - 1),
> duplicate_targets->nelts - 1);
> }
> return svn_error_createf(
> ]]]
Great!
You have my +1 to commit that, and any similar issues you find.
- Julian
Received on 2018-03-14 23:10:28 CET