Re: SHA-1 collision in repository?
From: Philip Martin <philip_at_codematters.co.uk>
Date: Thu, 08 Mar 2018 15:41:13 +0000
Nathan Hartman <hartman.nathan_at_gmail.com> writes:
> Is it possible and does it make sense to always continue reading until
I believe setting the expanded size correctly is the only fix we need.
> Alternatively, if reading up to the expanded size and then stopping,
Not sure. The caller often does just that but that essentially just
if (rb->off == rb->len)
and trivially returns 0. I suppose we could make a call to data
There is one additional check we should add, on trunk at least. This
> Have you had a chance to test against the 1.10 rc?
The trunk/1.10 code has been reworked and, as far as I can tell, the bug
-- PhilipReceived on 2018-03-08 16:41:22 CET
This is an archived mail posted to the Subversion Dev mailing list.