[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Potential regression: high server-side memory consumption during import

From: Philip Martin <philip_at_codematters.co.uk>
Date: Fri, 02 Mar 2018 21:40:28 +0000

Philip Martin <philip_at_codematters.co.uk> writes:

> Again, 1.10 would be nearly twice as fast, but now rereading the authz
> removes most of that gain.

I think I see the underlying problem: the authz code now incorporates a
cache based on the md5 checksum of the rules, so when the rules are
unchanged the cached value can be reused. This cache relies on the
caller being able to pass an svn_repos_t to svn_repos_authz_read3() and,
while svnserve does indeed pass such a pointer, mod_authz_svn is passing
NULL. That means mod_authz_svn does not take advantage of the new authz
cache.

Stefan's pool patch helps, but I believe the authz rereading in
mod_authz_svn should be reverted from 1.10 unless we can make it take
advantage of the new authz cache.

-- 
Philip
Received on 2018-03-02 22:40:33 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.