[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Reviewing 1.10 APIs & compatibility

From: Julian Foad <julianfoad_at_apache.org>
Date: Thu, 8 Feb 2018 11:27:52 +0000

Philip Martin wrote:
> Julian Foad <julianfoad_at_apache.org> writes:
>> Philip Martin wrote:
>>> First I ran the 1.9 testsuite against 1.10 servers
>>> over http:// and svn://. [...]
>>
>> Philip, please can you tell me how you did this?
>>
>> [...]
>>> I also ran the 1.10 testsuite against 1.9 servers over http:// and
>>> svn://. In order to run the svn:// tests I had to disable part of
>>> ra-test 10 as the 1.9 server doesn't have r1723865 and the 1.10
>>> testsuite would block.
>> [...]
>
> Perhaps I answered the wrong question. If you are asking how I disabled
> part of ra-test then I simply removed the code and recompiled. Looking
> at it again I'm not sure why I referred to test 10 as the problem code
> is in get_dir_test()

I meant how you tested 1.9 against 1.10 and 1.10 against 1.9 in general.
Thanks for your first reply about that. This additional info is also useful.

- Julian

> Index: ../src-1.10/subversion/tests/libsvn_ra/ra-test.c
> ===================================================================
> --- ../src-1.10/subversion/tests/libsvn_ra/ra-test.c (revision 1823419)
> +++ ../src-1.10/subversion/tests/libsvn_ra/ra-test.c (working copy)
> @@ -604,6 +604,7 @@ get_dir_test(const svn_test_opts_t *opts,
> SVN_DIRENT_KIND, pool),
> SVN_ERR_FS_NOT_FOUND);
>
> +#if 0
> /* Test fetching SVN_DIRENT_SIZE without SVN_DIRENT_KIND. */
> SVN_ERR(svn_ra_get_dir2(session, &dirents, NULL, NULL, "", 1,
> SVN_DIRENT_SIZE, pool));
> @@ -611,7 +612,6 @@ get_dir_test(const svn_test_opts_t *opts,
> ent = svn_hash_gets(dirents, "A");
> SVN_TEST_ASSERT(ent);
>
> -#if 0
> /* ra_serf has returns SVN_INVALID_SIZE instead of documented zero for
> * for directories. */
> SVN_TEST_INT_ASSERT(ent->size, 0);
>
Received on 2018-02-08 12:27:58 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.