[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.10 API review - svn_io_stdin_readline()

From: Stefan Sperling <stsp_at_apache.org>
Date: Tue, 16 Jan 2018 11:24:48 +0100

On Tue, Jan 16, 2018 at 09:36:42AM +0000, Julian Foad wrote:
> Stefan Sperling wrote:
> > On Tue, Jan 16, 2018 at 07:37:31AM +0100, Branko ─îibej wrote:
> > > 2. What's wrong with using svn_stream_readline() with
> > > svn_io_stream_for_stdin2()?
> > >
> > > In other words: I suspect this new function should be removed.
> [...]
> >
> > This function is in fact just a convenience wrapper around the two other
> > functions you mention.
> >
> > There are 7 callers of this function across our command line tools.
> > If this function is not deemed appropriate for the public API, I would just
> > move it to the libsvn_subr cmdline.c bag of helper functions. Agreed?
>
> That is also the thought that came to me overnight.
>
> Renamed and moved to svn_cmdline__stdin_readline() in r1821224.
>
> Thanks.
> - Julian

Thanks Julian!
Received on 2018-01-16 11:24:54 CET

This is an archived mail posted to the Subversion Dev mailing list.