[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

1.10 API review - svn_io_stdin_readline()

From: Julian Foad <julianfoad_at_apache.org>
Date: Mon, 15 Jan 2018 16:42:02 +0000

About this new-for-1.10 API:
[[[
/** Reads a string from stdin until a newline or EOF is found
  *
  * @since New in 1.10.
  */
svn_error_t *
svn_io_stdin_readline(const char **result,
                       apr_pool_t *result_pool,
                       apr_pool_t *scratch_pool);
]]]

Compare with svn_stream_readline() and svn_io_file_readline():
  * they read into a svn_stringbuf_t;
  * they have EOL and EOF params;
  * svn_io_file_readline() has max_len param;

It seems to me it would be better to make this new function more similar
to them.

Thoughts?

- Julian
Received on 2018-01-15 17:42:07 CET

This is an archived mail posted to the Subversion Dev mailing list.