On 30.12.2017 14:41, Branko Čibej wrote:
> On 30.12.2017 11:29, Branko Čibej wrote:
>> On 30.12.2017 11:07, Daniel Shahaf wrote:
>>> Daniel Shahaf wrote on Sat, 30 Dec 2017 10:00 +0000:
>>>> We've got an off-by-one somewhere.
>>> And here's a regression test. It passes if the expectation is "foo ar
>>> az" but fails if the expectation is "foo bar baz".
>> This bug seems to be new on trunk (and probably 1.10.x). I suspect the
>> authzperf branch merge, but haven't actually checked.
> Confirmed, this bug appeared in r1776832, which was the merge from the
> authzperf branch.
And fixed ...
[[[
Index: subversion/libsvn_subr/config_file.c
===================================================================
--- subversion/libsvn_subr/config_file.c (revision 1819597)
+++ subversion/libsvn_subr/config_file.c (working copy)
@@ -466,6 +466,7 @@
else
{
/* This is a continuation line. Read it. */
+ SVN_ERR(parser_ungetc(ctx, ch));
SVN_ERR(parser_get_line(ctx, ctx->line_read, &ch));
/* Trailing whitespace is ignored. */
]]]
I'll commit later today, with Daniel's text.
-- Brane
Received on 2017-12-30 14:52:19 CET