[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Reduce the amount of WriteFile() syscalls when writing to buffered files

From: Markus Schaber <m.schaber_at_codesys.com>
Date: Tue, 22 Aug 2017 06:42:29 +0000

Hi, Evgeny,

Great work, IMHO.

From: Evgeny Kotkov [mailto:evgeny.kotkov_at_visualsvn.com]
 
> This patch series reduces the amount of syscalls in such situations by
> performing a single WriteFile() call without any buffering, if possible.
> If some data is already buffered, then the buffer is first filled, flushed
> and the remaining part of the data is written with a single WriteFile().

Why first refilling the buffer, instead of flushing the partial buffer content, and then the original data to write?

From my first glance, it looks like the number of syscalls should be the same, and we could skip the mem copy?

Mit freundlichen Grüßen

Markus Schaber

CODESYS® Eine Marke der 3S-Smart Software Solutions GmbH

Inspiring Automation Solutions

3S-Smart Software Solutions GmbH
Dipl.-Inf. Markus Schaber | Product Development Core Technology
Memminger Str. 151 | 87439 Kempten
Tel. +49-831-54031-979 | Fax +49-831-54031-50

E-Mail: m.schaber@codesys.com | Web: http://www.codesys.com | CODESYS store: http://store.codesys.com
CODESYS forum: http://forum.codesys.com

Geschäftsführer: Dipl.Inf. Dieter Hess, Dipl.Inf. Manfred Werner | Handelsregister: Kempten HRB 6186 | USt-IDNr.: DE 167014915

Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind
oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail.
Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet.
Received on 2017-08-22 08:42:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.