[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

CR in notify.c

From: Philip Martin <philip_at_codematters.co.uk>
Date: Tue, 08 Aug 2017 23:04:55 +0100

When rolling trunk tarballs I notice the error:

../svn/notify.c:483: warning: internationalized messages should not contain the '\r' escape sequence

The '\r' is intentional, the notification is of the form:

  Checking r32...

and the \r causes the line to get overwritten as the revision changes.
I haven't tested what happens if the revision number gets shorter by
lots of digits, but I suspect that if a long first notification:

  Checking r1234567...

is followed by a short second:

  Checking r99...

the first will not be completely obliterated by the second.

Perhaps we should move the \r out of the internationalized message and
use it in some longer message that is guaranteed to obliterate any
previous message.

-- 
Philip
Received on 2017-08-09 00:05:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.