[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1803899 - in /subversion/trunk/subversion: libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 2 Aug 2017 21:16:43 +0200

On Wed, Aug 02, 2017 at 06:49:55PM -0000, kotkov_at_apache.org wrote:
> +svn_boolean_t
> +svn_ra_serf__is_local_network(svn_ra_serf__session_t *session)
> +{
> + return session->conn_latency >= 0 &&
> + session->conn_latency < apr_time_from_msec(5);
> +}

"local network" is a rather blurry concept.
This will often return FALSE for local wireless connections, for
example, because of shared medium contention.

I agree that 5msec is a well chosen latency threshold.
But why not name this function after the question it answers,
e.g. svn_ra_serf__is_low_latency_connection()?
Received on 2017-08-02 21:16:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.