Re: svn commit: r1801940 - in /subversion/trunk: ./ notes/ subversion/include/ subversion/include/private/ subversion/libsvn_delta/ subversion/libsvn_fs_fs/ subversion/libsvn_subr/ subversion/tests/libsvn_delta/ subversion/tests/libsvn_subr/

Stefan Sperling <stsp_at_elego.de> writes:

>> The way the lz4 code is currently embedded in libsvn_subr makes it
>> awkward to add support for an external liblz4.
>
> I agree that an external library should be used during the build.
> It makes life a lot easier for packagers on Unix-style systems,
> and is the expected de-facto standard in that ecosystem.

I would very much prefer if we didn't have the mandatory dependency on
the external LZ4 library.

This would be painful in case it's not available out of the box on the target
platform, and would add even more steps to the egregiously complicated
build process on Windows. And building using an embedded copy of the
source isn't something new, as we already do that for utf8proc and with
sqlite-amalgamation.

Furthermore, we only require the core part of the LZ4 library — that is, two
relatively small files (lz4.c and lz4.h), which I think were specifically
designed this way to simplify the process of using LZ4 in various
applications.

Regards,
Evgeny Kotkov
Received on 2017-07-26 14:49:04 CEST