[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1801940 - in /subversion/trunk: ./ notes/ subversion/include/ subversion/include/private/ subversion/libsvn_delta/ subversion/libsvn_fs_fs/ subversion/libsvn_subr/ subversion/tests/libsvn_delta/ subversion/tests/libsvn_subr/

From: Philip Martin <philip_at_codematters.co.uk>
Date: Wed, 26 Jul 2017 12:05:48 +0100

kotkov_at_apache.org writes:

> Author: kotkov
> Date: Fri Jul 14 11:13:47 2017
> New Revision: 1801940
>
> URL: http://svn.apache.org/viewvc?rev=1801940&view=rev
> Log:
> fsfs: Add initial support for LZ4 compression.

> * build.conf
> (libsvn_subr): Build LZ4 library sources.

Why do we have an embedded copy of the source code? That's not our
usual policy with 3rd party libraries and the LZ4 library is available
on Linux systems:

  $ pkg-config lz4 --libs
  -llz4

If the reason for embedding is simply to avoid an external dependency
then I think that is wrong -- we should not accumuate 3rd party code in
our code base. I suppose there could be an argument to embed the LZ4
code if the compressed form is not stable from one release to another.
Is that the case? If so then how stable is the current format?

-- 
Philip
Received on 2017-07-26 13:06:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.