Re: svn commit: r1801970 - in /subversion/branches/shelve-checkpoint/subversion: libsvn_client/shelve.c svn/shelve-cmd.c

Thanks for the review, Bert. I agree on all points.

- Julian

Bert Huijben wrote:
>> + for (hi = apr_hash_first(scratch_pool, dirents); hi; hi = apr_hash_next(hi))
>> {
>
> I know it is just a prototype, but some stable sorting would be nice.

>> + printf("%-30s %6d mins old %10ld bytes\n",
>> + name, age, (long)dirent->filesize);
>
> And in general we try to avoid the standard print functions as these might not be as compatible as expected. (UTF-8 support, buffering, etc.)

>> + system(apr_psprintf(scratch_pool, "diffstat %s 2> /dev/null", path));
>> + printf("\n");
>
> And this will certainly fail on Windows (but the error is ignored anyway). I would recommend flushing stdout before calling system() on other platforms.
Received on 2017-07-18 20:10:09 CEST