[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add ability to export a specific revision when a working copy path is supplied

From: Philip Martin <philip_at_codematters.co.uk>
Date: Mon, 17 Jul 2017 12:14:37 +0100

Doug Brown <doug_at_schmorgal.com> writes:

> * subversion/libsvn_client/export.c
> (export_directory): Ensure that from_path_or_url is converted to a URL prior
> to passing it to svn_client__export_externals.

svn_client_export5 has a top level if conditional:

   if (location is url) or (revision implies URL) then
      export from URL
   else
      export from WC

export_directory() is only ever called when exporting from an URL. I
think svn_client_export5() should be the one to convert the location to
an URL and the lower level export_file_ev2(), export_file() and
export_directory() should be changed to only handle URLs:

 - move the conversion from export_directory to svn_client_export5
 - change the parameter names in export_file_ev2, export_file,
   export_directory
 - remove the path code from those functions as it is never used
 - add SVN_ERR_ASSERT(svn_path_is_url(from_url))

-- 
Philip
Received on 2017-07-17 13:14:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.