[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1801108 - in /subversion/trunk/subversion/bindings/javahl/native: Array.cpp CreateJ.cpp Iterator.cpp OperationContext.cpp RemoteSession.cpp RevisionRangeList.cpp

From: Bert Huijben <bert_at_qqmail.nl>
Date: Fri, 7 Jul 2017 11:42:16 +0200

> -----Original Message-----
> From: philip_at_apache.org [mailto:philip_at_apache.org]
> Sent: donderdag 6 juli 2017 22:56
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1801108 - in
> /subversion/trunk/subversion/bindings/javahl/native: Array.cpp CreateJ.cpp
> Iterator.cpp OperationContext.cpp RemoteSession.cpp
> RevisionRangeList.cpp
>
> Author: philip
> Date: Thu Jul 6 20:56:14 2017
> New Revision: 1801108
>
> URL: http://svn.apache.org/viewvc?rev=1801108&view=rev
> Log:
> Add exception checks to some of the JavaHL native code to avoid JVM
> warnings about JNI problems of the form:
>
> WARNING in native method: JNI call made without checking exceptions
> when required to
>
> * subversion/bindings/javahl/native/Array.cpp
> (Array::init): Add exception check.
>
> * subversion/bindings/javahl/native/CreateJ.cpp
> (CreateJ::Mergeinfo): Add exception check.
>
> * subversion/bindings/javahl/native/Iterator.cpp
> (init_iterator, Iterator::next): Add exception check.
>
> * subversion/bindings/javahl/native/OperationContext.cpp
> (OperationContext::closeTunnel): Add exception check.
>
> * subversion/bindings/javahl/native/RemoteSession.cpp
> (build_string_array, long_iterable_to_revnum_array,
> location_hash_to_map): Add exception check.
>
> * subversion/bindings/javahl/native/RevisionRangeList.cpp
> (RevisionRangeList::RevisionRangeList): Add exception check.

Should we backport these to 1.9.x?

        Bert
Received on 2017-07-07 11:42:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.