[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1785734 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

From: Stefan Fuhrmann <stefan2_at_apache.org>
Date: Sat, 11 Mar 2017 18:21:42 +0100

On 06.03.2017 21:53, Daniel Shahaf wrote:
> stefan2_at_apache.org wrote on Mon, Mar 06, 2017 at 19:05:45 -0000:
>> +static svn_error_t *
>> +test_rep_sharing_strict_content_check(const svn_test_opts_t *opts,
>> + apr_pool_t *pool)
>> +{
>> + /* Bail (with success) on known-untestable scenarios */
>> + if (strcmp(opts->fs_type, SVN_FS_TYPE_BDB) == 0)
>> + return svn_error_create(SVN_ERR_TEST_SKIPPED, NULL,
>> + "this will not test BDB repositories");
> Minor point: the log message^W^W skip message should answer "Why", not
> "What". Suggestion:
>
> "bdb does not have a rep-cache"
>
I simply copied that from previous tests ...
Changed in r1786447.

-- Stefan^2.
Received on 2017-03-11 18:21:46 CET

This is an archived mail posted to the Subversion Dev mailing list.